soumitra-st commented on code in PR #13537:
URL: https://github.com/apache/pinot/pull/13537#discussion_r1674443643
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java:
##########
@@ -317,8 +317,10 @@ public synchronized String submitTask(String
parentTaskName, List<PinotTaskConfi
public synchronized Set<String> getTasks(String taskType) {
String helixJobQueueName = getHelixJobQueueName(taskType);
WorkflowConfig workflowConfig =
_taskDriver.getWorkflowConfig(helixJobQueueName);
- Preconditions.checkArgument(workflowConfig != null, "Task queue: %s for
task type: %s does not exist",
- helixJobQueueName, taskType);
+ if (workflowConfig == null) {
+ LOGGER.error("Task queue: {} for task type: {} does not exist",
helixJobQueueName, taskType);
Review Comment:
Good point, changed the log to info. I didn't find a way to check if the
task is valid but not the queue. In fact, there are other places in the code
which use task queue itself, for instance:
https://github.com/apache/pinot/blob/fb9f2953a2626c99412411a968f095bd0376521a/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java#L185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
