nanditajayanthi commented on code in PR #12966:
URL: https://github.com/apache/pinot/pull/12966#discussion_r1581272631
##########
pinot-plugins/pinot-input-format/pinot-parquet/src/test/java/org/apache/pinot/plugin/inputformat/parquet/ParquetNativeRecordReaderFullTest.java:
##########
@@ -123,19 +123,22 @@ protected void testReadDataSet2()
//testParquetFile("test-data2/uniform_encryption.parquet.encrypted");
}
- protected void testParquetFile(String filePath)
+protected void testParquetFile(String filePath)
throws Exception {
File dataFile = new
File(URLDecoder.decode(getClass().getClassLoader().getResource(filePath).getFile(),
"UTF-8"));
ParquetNativeRecordReader recordReader = new ParquetNativeRecordReader();
recordReader.init(dataFile, null, null);
+ int counter = 0;
Review Comment:
For this PR, I can count `numDocsForFirstPass` and `numDocsForSecondPass`
explicitly. This PR is mainly intended to add an assertion mechanism. Is it
still necessary to use the try-with-resource in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
