Jackie-Jiang commented on code in PR #12966:
URL: https://github.com/apache/pinot/pull/12966#discussion_r1571478256
##########
pinot-plugins/pinot-input-format/pinot-parquet/src/test/java/org/apache/pinot/plugin/inputformat/parquet/ParquetNativeRecordReaderFullTest.java:
##########
@@ -123,19 +123,22 @@ protected void testReadDataSet2()
//testParquetFile("test-data2/uniform_encryption.parquet.encrypted");
}
- protected void testParquetFile(String filePath)
+protected void testParquetFile(String filePath)
Review Comment:
Please fix the format
##########
pinot-plugins/pinot-input-format/pinot-parquet/src/test/java/org/apache/pinot/plugin/inputformat/parquet/ParquetNativeRecordReaderFullTest.java:
##########
@@ -123,19 +123,22 @@ protected void testReadDataSet2()
//testParquetFile("test-data2/uniform_encryption.parquet.encrypted");
}
- protected void testParquetFile(String filePath)
+protected void testParquetFile(String filePath)
throws Exception {
File dataFile = new
File(URLDecoder.decode(getClass().getClassLoader().getResource(filePath).getFile(),
"UTF-8"));
ParquetNativeRecordReader recordReader = new ParquetNativeRecordReader();
recordReader.init(dataFile, null, null);
+ int counter = 0;
Review Comment:
Would it be more explicit if we count `numDocsForFirstPass` and
`numDocsForSecondPass` and compare them? Can you also use try-with-resource to
close the record reader (not introduced in this PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
