shounakmk219 commented on code in PR #12940:
URL: https://github.com/apache/pinot/pull/12940#discussion_r1580459265
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java:
##########
@@ -135,6 +138,17 @@ protected void postprocess(Context context) {
_controllerMetrics.setValueOfGlobalGauge(ControllerGauge.UPSERT_TABLE_COUNT,
context._upsertTableCount);
_controllerMetrics.setValueOfGlobalGauge(ControllerGauge.DISABLED_TABLE_COUNT,
context._disabledTables.size());
+ _tierBackendGauges.forEach(_controllerMetrics::removeGauge);
Review Comment:
Yeah but there will be 1 entry per tier backend plugin which won't be much
so I thought we can avoid the complication of managing the previous/new diff
and just delete all gauges for the tiers which the controller has witnessed
since boot up. What you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
