shounakmk219 commented on code in PR #12940:
URL: https://github.com/apache/pinot/pull/12940#discussion_r1578050621


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java:
##########
@@ -135,6 +138,17 @@ protected void postprocess(Context context) {
     
_controllerMetrics.setValueOfGlobalGauge(ControllerGauge.UPSERT_TABLE_COUNT, 
context._upsertTableCount);
     
_controllerMetrics.setValueOfGlobalGauge(ControllerGauge.DISABLED_TABLE_COUNT, 
context._disabledTables.size());
 
+    _tierBackendGauges.forEach(_controllerMetrics::removeGauge);

Review Comment:
   I was using `_tierBackendGauges` just to remove all the existing tier 
gauges. It will be a superset of all the encountered tier backends. Anyways the 
loop on `context._tierBackendTableCountMap` takes care of recreating the 
required gauges.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to