itschrispeck commented on code in PR #11558:
URL: https://github.com/apache/pinot/pull/11558#discussion_r1323331770
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneDocIdCollector.java:
##########
@@ -60,9 +61,16 @@ public void setScorer(Scorable scorer)
@Override
public void collect(int doc)
throws IOException {
+ if (_shouldCancel) {
+ throw new RuntimeException("Lucene query was cancelled");
Review Comment:
It looks like 'cancelled' is mostly used for cancelling streaming queries,
'killed' being used for the OOM protection
It's still inconsistent as you said so I could update it to
`shouldTerminate` to keep the Collector interrupt generic and this will always
be wrapped by a TimeoutException , wdyt?
edit: it looks like `EarlyTerminationException` is also used by the query
killing feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
