siddharthteotia commented on code in PR #11558:
URL: https://github.com/apache/pinot/pull/11558#discussion_r1322620614
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneDocIdCollector.java:
##########
@@ -60,9 +61,16 @@ public void setScorer(Scorable scorer)
@Override
public void collect(int doc)
throws IOException {
+ if (_shouldCancel) {
+ throw new RuntimeException("Lucene query was cancelled");
Review Comment:
"Cancelled" here could be misleading / inconsistent with rest of the code
We should be clear about timeout based interruption vs query cancelled. The
latter terminology has been used for memory usage based query killing IIRC. cc
@jasperjiaguo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
