deemoliu commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1246999981
##########
pinot-controller/src/test/java/org/apache/pinot/controller/api/PinotSegmentRestletResourceTest.java:
##########
@@ -165,6 +166,39 @@ public void testSegmentCrcApi()
checkCrcRequest(rawTableName, segmentMetadataTable, 9);
}
+ @Test
+ public void testDeleteSegmentsWithTimeWindow()
+ throws Exception {
+ // Adding table and segment
+ String rawTableName = "deleteWithTimeWindowTestTable";
+ String offlineTableName =
TableNameBuilder.OFFLINE.tableNameWithType(rawTableName);
Review Comment:
can you add a test case that timeindow covers both realtime and offline
table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
