wirybeaver commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1230150645
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -884,6 +865,47 @@ public SuccessResponse deleteSegments(
}
}
+ @DELETE
+ @Consumes(MediaType.APPLICATION_JSON)
+ @Produces(MediaType.APPLICATION_JSON)
+ @Path("/segments/{tableName}/select")
+ @Authenticate(AccessType.DELETE)
+ @ApiOperation(value = "Delete select segments. An optional
'excludeReplacedSegments' parameter is used to get the"
+ + " list of segments which has not yet been replaced (determined by
segment lineage entries) and can be queried"
+ + " from the table. The value is false by default.",
+ // TODO: more and more filters can be added later on, like
excludeErrorSegments, excludeConsumingSegments, etc.
+ notes = "List all segments")
+ public SuccessResponse deleteSegmentsWithTimeWindow(
+ @ApiParam(value = "Name of the table", required = true)
@PathParam("tableName") String tableName,
+ @ApiParam(value = "OFFLINE|REALTIME") @QueryParam("type") String
tableTypeStr,
+ @ApiParam(value = "Whether to keep replaced segments, which have been
replaced"
+ + " specified in the segment lineage entries and cannot be queried
from the table, false by default")
+ @QueryParam("excludeReplacedSegments") @DefaultValue("false") boolean
excludeReplacedSegments,
+ @ApiParam(value = "Start timestamp (inclusive)")
@QueryParam("startTimestamp") @DefaultValue("")
+ String startTimestampStr,
+ @ApiParam(value = "End timestamp (exclusive)")
@QueryParam("endTimestamp") @DefaultValue("")
+ String endTimestampStr,
+ @ApiParam(value = "Whether to keep segments overlapping with the [start,
end) from deletion, true by default")
+ @QueryParam("excludeOverlapping") @DefaultValue("true") boolean
excludeOverlapping,
Review Comment:
Rephrase the ApiParam value. keep segments -> ignore segments for deletion.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -1130,4 +1152,38 @@ private SuccessResponse
updateZKTimeIntervalInternal(String tableNameWithType) {
}
return new SuccessResponse("Successfully updated time interval zk
metadata for table: " + tableNameWithType);
}
+
+ public List<Pair<TableType, List<String>>> selectSegments(
Review Comment:
getSelectedSegments() has annotation Deprecated. The getSegments() is
refactored with this util function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
