snleee commented on code in PR #10869:
URL: https://github.com/apache/pinot/pull/10869#discussion_r1222291763
##########
pinot-core/src/main/java/org/apache/pinot/core/minion/SegmentPurger.java:
##########
@@ -79,7 +82,7 @@ public File purgeSegment()
return null;
}
- SegmentGeneratorConfig config = new SegmentGeneratorConfig(_tableConfig,
segmentMetadata.getSchema());
+ SegmentGeneratorConfig config = new SegmentGeneratorConfig(_tableConfig,
_schema);
Review Comment:
If `_schema = null`, probably it's safer to fall back to
`segmentMetadata.getSchema()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
