sajjad-moradi commented on code in PR #10869:
URL: https://github.com/apache/pinot/pull/10869#discussion_r1222188549
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/PurgeMinionClusterIntegrationTest.java:
##########
@@ -96,23 +98,27 @@ public void setUp()
TableConfig purgeDeltaPassedTableConfig = createOfflineTableConfig();
purgeDeltaPassedTableConfig.setTaskConfig(getPurgeTaskConfig());
+ setTableName(PURGE_OLD_SEGMENTS_WITH_NEW_INDICES_TABLE);
+ TableConfig purgeOldSegmentsWithNewIndicesTableConfig =
createOfflineTableConfig();
+
purgeOldSegmentsWithNewIndicesTableConfig.setTaskConfig(getPurgeTaskConfig());
+
addTableConfig(purgeTableConfig);
addTableConfig(purgeDeltaPassedTableConfig);
addTableConfig(purgeDeltaNotPassedTableConfig);
+ addTableConfig(purgeOldSegmentsWithNewIndicesTableConfig);
// Unpack the Avro files
List<File> avroFiles = unpackAvroData(_tempDir);
- // Create and upload segments
- ClusterIntegrationTestUtils.buildSegmentsFromAvro(avroFiles,
purgeTableConfig, schema, 0, _segmentDir1, _tarDir1);
Review Comment:
That wasn't needed. The schema and table configs for all those three tables
were the same, so were the segments that were built. So there's no need to
build the segments three times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
