jugomezv commented on code in PR #10777:
URL: https://github.com/apache/pinot/pull/10777#discussion_r1204433164
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/retry/RetryPolicy.java:
##########
@@ -33,7 +33,8 @@ public interface RetryPolicy {
* @param operation The operation to attempt, which returns true on success
and false on failure.
* @throws AttemptsExceededException
* @throws RetriableOperationException
+ * @return the number of attempts used for the operation. 0 means the first
try was successful.
*/
- void attempt(Callable<Boolean> operation)
+ int attempt(Callable<Boolean> operation)
Review Comment:
The challenge is when you throw, you don't return a value. I could assume is
the max Retry count and add that, else this change continues to sprawl by
adding a new out arg to that method that may need to change everything that
uses it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
