jugomezv commented on code in PR #10777:
URL: https://github.com/apache/pinot/pull/10777#discussion_r1201268380
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/fetcher/BaseSegmentFetcher.java:
##########
@@ -102,7 +104,8 @@ public void fetchSegmentToLocal(List<URI> uris, File dest)
});
}
- public File fetchUntarSegmentToLocalStreamed(URI uri, File dest, long
rateLimit)
+ public File fetchUntarSegmentToLocalStreamed(URI uri, File dest, long
rateLimit,
+ AtomicInteger attempts)
Review Comment:
I looked into bubbling up the attempts in the other calls like
fetchSegmentToLocal() but it will not make sense for the metric we are trying
to maintain, we would have to define new metrics and at this point we don't
need those. These calls are also used from controllers and realtime so they
will sprawl metrics to other places so I will skip that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
