jugomezv commented on code in PR #10777:
URL: https://github.com/apache/pinot/pull/10777#discussion_r1198102431
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -628,9 +628,15 @@ private File downloadAndStreamUntarWithRateLimit(String
segmentName, SegmentZKMe
maxStreamRateInByte);
String uri = zkMetadata.getDownloadUrl();
try {
- File ret = SegmentFetcherFactory.fetchAndStreamUntarToLocal(uri,
tempRootDir, maxStreamRateInByte);
- LOGGER.info("Download and untarred segment: {} for table: {} from: {}",
segmentName, _tableNameWithType, uri);
- return ret;
+ try {
+ File ret = SegmentFetcherFactory.fetchAndStreamUntarToLocal(uri,
tempRootDir, maxStreamRateInByte);
+ LOGGER.info("Download and untarred segment: {} for table: {} from:
{}", segmentName, _tableNameWithType, uri);
+ return ret;
+ } catch (Exception e) {
+ _serverMetrics.addMeteredTableValue(_tableNameWithType,
+ ServerMeter.SEGMENT_TOTAL_STREAMED_DOWNLOAD_UNTAR_FAILURES, 1L);
Review Comment:
That is what I though, so to make sure we are in sync: we will redefine the
old metric to tick on individual failures and may be just log when we exceed
the max retries?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
