navina commented on code in PR #10777:
URL: https://github.com/apache/pinot/pull/10777#discussion_r1197155941
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java:
##########
@@ -70,6 +70,7 @@ public enum ServerMeter implements AbstractMetrics.Meter {
REFRESH_FAILURES("segments", false),
UNTAR_FAILURES("segments", false),
SEGMENT_STREAMED_DOWNLOAD_UNTAR_FAILURES("segments", false),
+ SEGMENT_TOTAL_STREAMED_DOWNLOAD_UNTAR_FAILURES("segments", false),
Review Comment:
Can you please add metrics description as a part of this definition? You can
see some examples in
[`ServerTimer`](https://github.com/apache/pinot/blob/master/pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerTimer.java#L29)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
