mqliang commented on a change in pull request #7585:
URL: https://github.com/apache/pinot/pull/7585#discussion_r732136045
##########
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/SegmentConversionUtils.java
##########
@@ -72,19 +76,33 @@ public static void uploadSegment(Map<String, String>
configs, List<Header> httpH
// Upload the segment with retry policy
SSLContext sslContext = MinionContext.getInstance().getSSLContext();
+ // Create a RoundRobinURIProvider to round robin IP addresses when retry
uploading. Otherwise may always try to
+ // upload to a same broken host as: 1) DNS may not RR the IP addresses 2)
OS cache the DNS resolution result.
+ RoundRobinURIProvider uriProvider = new RoundRobinURIProvider(new
URI(uploadURL));
Review comment:
It seems the retry logic is out of the task implementation. Not a helix
expert, but it seems it's helix that retry a task, not task implement the retry
logic inside it's implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
