mqliang commented on a change in pull request #7585:
URL: https://github.com/apache/pinot/pull/7585#discussion_r732134187
##########
File path: pinot-common/pom.xml
##########
@@ -245,7 +245,7 @@
</dependency>
<dependency>
<groupId>org.mockito</groupId>
- <artifactId>mockito-core</artifactId>
+ <artifactId>mockito-inline</artifactId>
Review comment:
unit test need to mock a static function`InetAddress.getAllByName()`,
`mockito-core` does not support mocking static function:
```
org.mockito.exceptions.base.MockitoException:
The used MockMaker SubclassByteBuddyMockMaker does not support the creation
of static mocks
Mockito's inline mock maker supports static mocks based on the
Instrumentation API.
You can simply enable this mock mode, by placing the 'mockito-inline'
artifact where you are currently using 'mockito-core'.
Note that Mockito's inline mock maker is not supported on Android.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
