richardstartin commented on a change in pull request #7583:
URL: https://github.com/apache/pinot/pull/7583#discussion_r729922787
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/utils/JsonUtils.java
##########
@@ -82,6 +82,12 @@ private JsonUtils() {
return DEFAULT_READER.forType(valueTypeRef).readValue(jsonString);
}
+ public static <T> List<T> stringToList(String jsonString, Class<T> valueType)
Review comment:
I really think these should be tested though. If all new code is tested,
coverage can't get worse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
