walterddr commented on a change in pull request #7583:
URL: https://github.com/apache/pinot/pull/7583#discussion_r729920407
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/utils/JsonUtils.java
##########
@@ -82,6 +82,12 @@ private JsonUtils() {
return DEFAULT_READER.forType(valueTypeRef).readValue(jsonString);
}
+ public static <T> List<T> stringToList(String jsonString, Class<T> valueType)
Review comment:
dont know where to add test the best, it doesn't seem like the others
are tested individually either.
##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/utils/JsonUtils.java
##########
@@ -82,6 +82,12 @@ private JsonUtils() {
return DEFAULT_READER.forType(valueTypeRef).readValue(jsonString);
}
+ public static <T> List<T> stringToList(String jsonString, Class<T> valueType)
Review comment:
sounds good. I take this as ok to create a separate test file entirely
to cover the non-tested JsonUtils functions. will do it soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
