Jackie-Jiang commented on a change in pull request #7222:
URL: https://github.com/apache/pinot/pull/7222#discussion_r684850946
##########
File path: pinot-plugins/pinot-stream-ingestion/pinot-pulsar/pom.xml
##########
@@ -58,6 +58,16 @@
<okio.version>1.6.0</okio.version>
</properties>
+ <dependencyManagement>
Review comment:
Should we move this to the top level (`pinot`) pom.file? Other netty
related dependencies are all managed there
##########
File path: pinot-integration-tests/pom.xml
##########
@@ -124,6 +128,74 @@
</build>
</profile>
</profiles>
+
+ <!-- cloud.localstack:localstack-utils brings in slightly older versions of
all of
Review comment:
Curious on why we need to add these dependency management to a test
package. I don't think any test depends on the awssdk.
Adding @xiangfu0 to take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
