kkrugler commented on a change in pull request #7222:
URL: https://github.com/apache/pinot/pull/7222#discussion_r684701630
##########
File path:
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-common/src/main/java/org/apache/pinot/plugin/ingestion/batch/common/SegmentGenerationJobUtils.java
##########
@@ -43,4 +43,5 @@ public static boolean
useGlobalDirectorySequenceId(SegmentNameGeneratorSpec spec
}
return Boolean.parseBoolean(useGlobalDirectorySequenceId);
}
+
Review comment:
I've removed this empty line, and others.
However I'm using the Pinot code format settings for Eclipse, or at least
that's what Eclipse is telling me. But when I select the above file (for
example) and format it, (a) the blank line isn't removed, and (b) lines > 100
chars are re-wrapped, generating a lot of changes. Are you saying the blank
line should have been removed? And that you want me to go ahead and re-format
any file I touch, and that's OK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
