abhishekbafna commented on code in PR #17842:
URL: https://github.com/apache/pinot/pull/17842#discussion_r2929957652
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/HelixHelper.java:
##########
@@ -535,23 +537,43 @@ public static Set<InstanceConfig>
getBrokerInstanceConfigsForTenant(List<Instanc
public static Set<String> getTablesForBrokerTag(HelixManager helixManager,
String brokerTag) {
Set<String> tablesForBrokerTag = new HashSet<>();
- List<TableConfig> tableConfigs =
ZKMetadataProvider.getAllTableConfigs(helixManager.getHelixPropertyStore());
+ ZkHelixPropertyStore<ZNRecord> propertyStore =
helixManager.getHelixPropertyStore();
+ List<TableConfig> tableConfigs =
ZKMetadataProvider.getAllTableConfigs(propertyStore);
for (TableConfig tableConfig : tableConfigs) {
if
(TagNameUtils.getBrokerTagForTenant(tableConfig.getTenantConfig().getBroker()).equals(brokerTag))
{
tablesForBrokerTag.add(tableConfig.getTableName());
}
}
+ // Include logical tables that use this broker tenant (broker resource
partition name = logical table name)
+ for (LogicalTableConfig logicalTableConfig :
ZKMetadataProvider.getAllLogicalTableConfigs(propertyStore)) {
+ String logicalBrokerTag =
+
TagNameUtils.getBrokerTagForTenant(logicalTableConfig.getBrokerTenant() != null
Review Comment:
No. It would not return null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
