abhishekbafna commented on code in PR #17842:
URL: https://github.com/apache/pinot/pull/17842#discussion_r2929552967
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -748,6 +748,29 @@ public List<String> getAllTables() {
return
getAllResources().stream().filter(TableNameBuilder::isTableResource).collect(Collectors.toList());
}
+ /**
+ * Returns partition names in broker resource ideal state that are logical
tables (have logical table config
+ * and no physical table config). Used by broker resource validation to
repair logical table broker assignments.
+ * Identifies by config presence rather than name to avoid misclassifying
logical tables named with
+ * _OFFLINE/_REALTIME.
+ */
+ public List<String> getBrokerResourceLogicalTablePartitions() {
Review Comment:
Yeah. we can do that. Earlier I created an table with `_offline` suffix and
it was created successfully. Now I tried with `_OFFLINE` and it failed. So I
think, we can use the simpler approach. This is not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
