praveenc7 commented on code in PR #16672:
URL: https://github.com/apache/pinot/pull/16672#discussion_r2376901294
##########
pinot-common/src/main/java/org/apache/pinot/common/messages/QueryWorkloadRefreshMessage.java:
##########
@@ -45,7 +45,10 @@ public QueryWorkloadRefreshMessage(String queryWorkloadName,
String messageSubTy
setMsgSubType(messageSubType);
// Give it infinite time to process the message, as long as session is
alive
setExecutionTimeout(-1);
- QueryWorkloadConfigUtils.updateZNRecordWithInstanceCost(getRecord(),
queryWorkloadName, instanceCost);
+ // We don't expect the instance cost for non-refresh message
+ if (messageSubType.equals(REFRESH_QUERY_WORKLOAD_MSG_SUB_TYPE)) {
+ QueryWorkloadConfigUtils.updateZNRecordWithInstanceCost(getRecord(),
queryWorkloadName, instanceCost);
Review Comment:
This was based on the comment earlier, where we decided to have null
`InstanceCost`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
