praveenc7 commented on code in PR #16672:
URL: https://github.com/apache/pinot/pull/16672#discussion_r2370727257
##########
pinot-controller/src/main/java/org/apache/pinot/controller/workload/QueryWorkloadManager.java:
##########
@@ -263,9 +275,10 @@ public void propagateWorkloadFor(String tableName) {
LOGGER.info("Successfully propagated {} out of {} workloads for table:
{}",
successCount, queryWorkloadConfigsForTags.size(), tableName);
} catch (Exception e) {
+ // TODO: Find a way to report partial success/failure
String errorMsg = String.format("Failed to propagate workload for table:
%s", tableName);
LOGGER.error(errorMsg, e);
- throw new RuntimeException(errorMsg, e);
+ // Just log and return, we don't want to fail table operations due to
workload propagation issues
Review Comment:
This is called during table creation, table config change and end of
rebalance. For now until completely tested. Want to avoid blocking those
operation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
