wirybeaver opened a new issue, #16629: URL: https://github.com/apache/pinot/issues/16629
The PR https://github.com/apache/pinot/pull/13590 remove the DataTable V2 and V3 class between 1.2-rc and 1.3-rc. When we follow the general major version guide which suggesting to upgrade pinot-broker prior to the pinot-server in our testing environment, all queries failed because the java property file of pinot-server still set the `pinot.server.instance.currentDataTableVersion` = 2. https://sourcegraph.com/github.com/apache/pinot@231bf04f4af38093936dc73c1ea9ca4c9a95e942/-/blob/pinot-common/src/main/java/org/apache/pinot/common/datatable/DataTableFactory.java?L35 ``` public static DataTable getDataTable(ByteBuffer byteBuffer) throws IOException { int version = byteBuffer.getInt(); Preconditions.checkState(version == VERSION_4, "Unsupported data table version: %s", version); return new DataTableImplV4(byteBuffer); } ``` @Jackie-Jiang Do you have any suggestion here for the 1.3 version upgrade? Setting the pinot.server.instance.currentDataTableVersion=4 is one option but is risky due to Uber's complex config file management system. Another option is revert this change on our internal pinot repo, release and then ameliorate our config file system afterwards. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
