9aman commented on code in PR #16437:
URL: https://github.com/apache/pinot/pull/16437#discussion_r2238872919
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java:
##########
@@ -369,6 +369,9 @@ private void updateSegmentMetrics(String tableNameWithType,
TableConfig tableCon
if ((segmentState.equals(SegmentStateModel.ONLINE) ||
segmentState.equals(SegmentStateModel.CONSUMING))
&&
isServerQueryable(serverQueryInfoFetcher.getServerQueryInfo(serverInstanceId)))
{
numEVReplicasUp++;
+ } else {
+ LOGGER.warn("Segment {} in table {} has instance {} in state {}
and is unavailable",
Review Comment:
Would it be better to log separately for the case when the segment is
OFFLINE vs when the server is not reachable.
The first one can happen due to slow state transitions at restarts, any
deadlock etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
