yashmayya commented on code in PR #16437:
URL: https://github.com/apache/pinot/pull/16437#discussion_r2235678655
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java:
##########
@@ -369,6 +369,9 @@ private void updateSegmentMetrics(String tableNameWithType,
TableConfig tableCon
if ((segmentState.equals(SegmentStateModel.ONLINE) ||
segmentState.equals(SegmentStateModel.CONSUMING))
&&
isServerQueryable(serverQueryInfoFetcher.getServerQueryInfo(serverInstanceId)))
{
numEVReplicasUp++;
+ } else {
+ LOGGER.warn("Segment {} in table {} has instance {} in state {}
and is unavailable",
Review Comment:
nit: `instance 'xyz' in state 'abc'` sounds a bit misleading because the
state is associated with the segment, not the instance. How about `Segment {}
in table {} has state {} on instance {} and is unavailable` instead?
##########
pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java:
##########
@@ -31,10 +31,14 @@ private MinionConstants() {
public static final String TASK_TIME_SUFFIX = ".time";
public static final String TABLE_NAME_KEY = "tableName";
+
+ // Input segment name(s) and download url(s) for those segments for the
minion task.
+ // If there are multiple segments, they are separated by
SEGMENT_NAME_SEPARATOR.
+ // The index of the segment name and download url is the same for the same
segment.
public static final String SEGMENT_NAME_KEY = "segmentName";
public static final String DOWNLOAD_URL_KEY = "downloadURL";
+
public static final String UPLOAD_URL_KEY = "uploadURL";
- public static final String DOT_SEPARATOR = ".";
public static final String URL_SEPARATOR = ",";
Review Comment:
These changes are unrelated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
