xiangfu0 commented on code in PR #16380:
URL: https://github.com/apache/pinot/pull/16380#discussion_r2224797561
##########
pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java:
##########
@@ -786,6 +811,12 @@ public void runOnce() {
reapFinishedTasks();
if (_triggeringLevel.ordinal() > TriggeringLevel.Normal.ordinal()) {
_aggregatedUsagePerActiveQuery = getQueryResourcesImpl();
+ _aggregatedUsagePerActiveQuery.values().stream()
+ .filter(stats ->
!_cancelSentQueries.contains(stats.getQueryId()))
Review Comment:
we should kill all the queries associated with a global id.
Also the accounting should be grouped all queries together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
