gortiz commented on code in PR #16380:
URL: https://github.com/apache/pinot/pull/16380#discussion_r2221655435
##########
pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java:
##########
@@ -140,6 +141,8 @@ public static class PerQueryCPUMemResourceUsageAccountant
implements ThreadResou
protected Set<String> _cancelSentQueries;
+ protected String _maxMemoryUsageQueryId;
Review Comment:
BTW, is this attribute modified in a single thread fashion?
##########
pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java:
##########
@@ -140,6 +141,8 @@ public static class PerQueryCPUMemResourceUsageAccountant
implements ThreadResou
protected Set<String> _cancelSentQueries;
+ protected String _maxMemoryUsageQueryId;
Review Comment:
nit: rememer to mark it as `@Nullable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
