Jackie-Jiang commented on PR #16334: URL: https://github.com/apache/pinot/pull/16334#issuecomment-3105213635
I understand it is not impacting the query path, but it is indeed adding unnecessary overhead to the update path, and also emitting unnecessary metrics if user is not using the zone failure tolerant feature (most users won't use it). Each invocation of `getPool()` is a map lookup, which could also potentially log a warning. We don't want to call it on a per segment per replica basis unless the feature is enabled -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
