wirybeaver commented on PR #16334:
URL: https://github.com/apache/pinot/pull/16334#issuecomment-3090722174
> Not introduced in this PR, but seems pool is relevant only when
`PriorityPoolInstanceSelector` is used. Can we refactor/clean up the code so
that it won't add overhead for other scenarios?
I could add the condition "if (_priorityPoolInstanceSelector!=null) { //
emit metric}". But conceptually, the priorityPoolInstanceSelector is used when
there's a query traffic (segment read path). The metric emit happens for every
HelixMessage change of IdeaState and ExternalView (segment write path). The
write and read path. Essentially, we want to check whether every segment is
distributed across multiple pools.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
