shounakmk219 commented on code in PR #16383:
URL: https://github.com/apache/pinot/pull/16383#discussion_r2216082272


##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/ControllerRequestURLBuilder.java:
##########
@@ -382,7 +410,12 @@ public String forSchemaDelete(String schemaName) {
   }
 
   public String forTableConfigsCreate() {
-    return StringUtil.join("/", _baseUrl, "tableConfigs");
+    return forTableConfigsCreate(true);
+  }
+
+  public String forTableConfigsCreate(boolean ignoreActiveTasks) {

Review Comment:
   Agree with you on having the default same across tests as well. I am yet to 
access the impact as well. Raised this PR in order to revert the behaviour 
change for now on tests until the ideal fix is made.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to