yashmayya commented on code in PR #16383:
URL: https://github.com/apache/pinot/pull/16383#discussion_r2215995531
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/ControllerRequestURLBuilder.java:
##########
@@ -382,7 +410,12 @@ public String forSchemaDelete(String schemaName) {
}
public String forTableConfigsCreate() {
- return StringUtil.join("/", _baseUrl, "tableConfigs");
+ return forTableConfigsCreate(true);
+ }
+
+ public String forTableConfigsCreate(boolean ignoreActiveTasks) {
Review Comment:
> In order to avoid affecting the existing usage that may not have ensured
task completion before table deletion, this PR skips the active task check by
default on ControllerRequestURLBuilder unless specified
Can you please elaborate on the kind of test failures we're seeing due to
this? It seems a little strange to make the test default the opposite of the
regular default. Is it not possible to modify the tests to wait for task
completion and / or explicitly remove tasks before deletion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
