shauryachats commented on code in PR #16167:
URL: https://github.com/apache/pinot/pull/16167#discussion_r2163004961
##########
pinot-timeseries/pinot-timeseries-planner/src/main/java/org/apache/pinot/tsdb/planner/physical/TimeSeriesDispatchablePlan.java:
##########
@@ -35,11 +35,12 @@ public class TimeSeriesDispatchablePlan {
private final Map<String, Map<String, List<String>>>
_leafIdToSegmentsByInstanceId;
private final Map<String, Integer> _numInputServersForExchangePlanNode;
private final List<String> _serializedServerFragments;
+ private final String _tableName;
public TimeSeriesDispatchablePlan(String language,
List<TimeSeriesQueryServerInstance> queryServerInstances,
BaseTimeSeriesPlanNode brokerFragment, List<BaseTimeSeriesPlanNode>
serverFragments,
TimeBuckets initialTimeBuckets, Map<String, Map<String, List<String>>>
leafIdToSegmentsByInstanceId,
- Map<String, Integer> numInputServersForExchangePlanNode) {
+ Map<String, Integer> numInputServersForExchangePlanNode, String
tableName) {
Review Comment:
Makes sense. I can move the `TableScanVisitor.Context` outside
`buildPhysicalPlan` and changed the tables to a `List<String>`.
##########
pinot-timeseries/pinot-timeseries-planner/src/main/java/org/apache/pinot/tsdb/planner/physical/TimeSeriesDispatchablePlan.java:
##########
@@ -35,11 +35,12 @@ public class TimeSeriesDispatchablePlan {
private final Map<String, Map<String, List<String>>>
_leafIdToSegmentsByInstanceId;
private final Map<String, Integer> _numInputServersForExchangePlanNode;
private final List<String> _serializedServerFragments;
+ private final String _tableName;
public TimeSeriesDispatchablePlan(String language,
List<TimeSeriesQueryServerInstance> queryServerInstances,
BaseTimeSeriesPlanNode brokerFragment, List<BaseTimeSeriesPlanNode>
serverFragments,
TimeBuckets initialTimeBuckets, Map<String, Map<String, List<String>>>
leafIdToSegmentsByInstanceId,
- Map<String, Integer> numInputServersForExchangePlanNode) {
+ Map<String, Integer> numInputServersForExchangePlanNode, String
tableName) {
Review Comment:
Makes sense. I can move the `TableScanVisitor.Context` outside
`buildPhysicalPlan` and change the tables to a `List<String>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
