shauryachats commented on code in PR #16167:
URL: https://github.com/apache/pinot/pull/16167#discussion_r2164942401
##########
pinot-timeseries/pinot-timeseries-planner/src/main/java/org/apache/pinot/tsdb/planner/physical/TableScanVisitor.java:
##########
@@ -61,6 +61,7 @@ public void assignSegmentsToPlan(BaseTimeSeriesPlanNode
planNode, TimeBuckets ti
if (planNode instanceof LeafTimeSeriesPlanNode) {
LeafTimeSeriesPlanNode sfpNode = (LeafTimeSeriesPlanNode) planNode;
Expression filterExpression =
CalciteSqlParser.compileToExpression(sfpNode.getEffectiveFilter(timeBuckets));
+ context.addTableName(sfpNode.getTableName());
Review Comment:
These are full table names since the raw table name is converted to full
before this flow is invoked.
For auth actions, it does not matter because in either case, the raw table
name should be extracted within the `hasAccess` implementations. (In
[ZkBasicAuthAccessControlFactory](https://github.com/apache/pinot/blob/master/pinot-broker/src/main/java/org/apache/pinot/broker/broker/ZkBasicAuthAccessControlFactory.java#L116)
it is the case but not for
[BasicAuthAccessControlFactory](https://github.com/apache/pinot/blob/master/pinot-broker/src/main/java/org/apache/pinot/broker/broker/BasicAuthAccessControlFactory.java#L129)
which seems like an oversight.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
