J-HowHuang commented on code in PR #16096:
URL: https://github.com/apache/pinot/pull/16096#discussion_r2164568092
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/TableRebalanceIntegrationTest.java:
##########
@@ -1726,4 +1556,82 @@ private void waitForTableEVISConverge(String tableName,
long timeoutMs) {
}
}, 1000L, timeoutMs, "Failed to converge EV and IS for table: " +
tableName);
}
+
+ /**
+ * Helper method to perform segment moving test with specified configuration.
+ * Changes the table tenant, executes rebalance with force commit, and
verifies if segments were committed.
+ */
+ void performSegmentMovingTest(RebalanceConfig rebalanceConfig, TableConfig
tableConfig, String newTenant,
+ boolean shouldCommit, long timeoutMs)
throws Exception {
+ performSegmentMovingTest(rebalanceConfig, tableConfig, newTenant,
shouldCommit, timeoutMs, false);
+ }
+
+ /**
+ * Helper method to perform segment moving test with EVIS convergence wait.
+ * Similar to performSegmentMovingTest but waits for external view/ideal
state convergence instead of rebalance completion.
+ */
+ void performSegmentMovingTestWithEVISConverge(RebalanceConfig
rebalanceConfig, TableConfig tableConfig,
+ String newTenant,
boolean shouldCommit, long timeoutMs) throws Exception {
+ performSegmentMovingTest(rebalanceConfig, tableConfig, newTenant,
shouldCommit, timeoutMs, true);
+ }
+
+ /**
+ * Helper method to perform segment moving test with specified configuration.
+ * Changes the table tenant, executes rebalance with force commit, and
verifies if segments were committed.
+ *
+ * @param rebalanceConfig the rebalance configuration
+ * @param tableConfig the table configuration
+ * @param newTenant the new tenant to move segments to
+ * @param shouldCommit whether segments should be committed (affects
verification)
+ * @param timeoutMs timeout in milliseconds
+ * @param waitForEVISConverge if true, waits for external view/ideal state
convergence; if false, waits for rebalance completion
+ */
+ private void performSegmentMovingTest(RebalanceConfig rebalanceConfig,
TableConfig tableConfig, String newTenant,
Review Comment:
Done. Btw they share `BaseClusterIntegrationTest` instead of
`BaseClusterIntegrationTestSet`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
