J-HowHuang commented on code in PR #16096:
URL: https://github.com/apache/pinot/pull/16096#discussion_r2159590232
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -673,6 +673,14 @@ public RebalanceResult rebalance(
@QueryParam("retryInitialDelayInMs") long retryInitialDelayInMs,
@ApiParam(value = "Whether to update segment target tier as part of the
rebalance") @DefaultValue("false")
@QueryParam("updateTargetTier") boolean updateTargetTier,
+ @ApiParam(value = "Do force commit on consuming segments before they are
rebalanced") @DefaultValue("false")
+ @QueryParam("forceCommit") boolean forceCommit,
+ @ApiParam(value = "Batch size for force commit operations")
@DefaultValue("2147483647")
+ @QueryParam("forceCommitBatchSize") int forceCommitBatchSize,
+ @ApiParam(value = "Interval in milliseconds for checking force commit
batch status") @DefaultValue("5000")
+ @QueryParam("forceCommitBatchStatusCheckIntervalMs") int
forceCommitBatchStatusCheckIntervalMs,
+ @ApiParam(value = "Timeout in milliseconds for force commit batch status
check") @DefaultValue("180000")
Review Comment:
Added the constants in `ForceCommitBatchConfig`, changed the reference in
forceCommit API as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
