vrajat commented on code in PR #16051:
URL: https://github.com/apache/pinot/pull/16051#discussion_r2151932619
##########
pinot-spi/src/main/java/org/apache/pinot/spi/accounting/ThreadResourceUsageProvider.java:
##########
@@ -51,22 +51,28 @@ public class ThreadResourceUsageProvider {
private static boolean _isThreadCpuTimeMeasurementEnabled = false;
private static boolean _isThreadMemoryMeasurementEnabled = false;
- // reference point for start time/bytes
- private final long _startTimeNs;
- private final long _startBytesAllocated;
+ @Deprecated
+ public long getThreadTimeNs() {
+ return 0;
+ }
+
+ @Deprecated
+ public long getThreadAllocatedBytes() {
+ return 0;
+ }
Review Comment:
I had a similar conversation with @vvivekiyer as well. I had suggested a
separate PR to remove all the unnecessary code in a single PR. There will be a
few more code blocks deprecated as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
