vrajat commented on code in PR #16051: URL: https://github.com/apache/pinot/pull/16051#discussion_r2151777368
########## pinot-spi/src/main/java/org/apache/pinot/spi/accounting/ThreadResourceSnapshot.java: ########## @@ -0,0 +1,76 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.accounting; + +/** + * ThreadResourceSnapshot is a utility class that helps to track the CPU time and memory allocated. + * {@link ThreadResourceUsageProvider} provides cumulative CPU time and memory allocated for the current thread. + * This class uses that provider to snapshot start & end values for a task executed by that thread. + */ +public class ThreadResourceSnapshot { + private long _startCpuTime; + private long _startAllocatedBytes; + + private long _endCpuTime; + private long _endAllocatedBytes; + + /** + * Creates a new tracker and takes initial snapshots. + */ + public ThreadResourceSnapshot() { + reset(); + } + + public void reset() { + _startCpuTime = ThreadResourceUsageProvider.getCurrentThreadCpuTime(); + _startAllocatedBytes = ThreadResourceUsageProvider.getCurrentThreadAllocatedBytes(); + _endCpuTime = _startCpuTime; + _endAllocatedBytes = _startAllocatedBytes; + } + + /** + * Gets the CPU time used so far in nanoseconds. + * Takes a current snapshot if not yet closed. + */ + public long getCpuTimeNs() { + return _endCpuTime - _startCpuTime; + } Review Comment: I've fixed the javadoc and the code. This was left over from an initial version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
