gortiz commented on code in PR #15919:
URL: https://github.com/apache/pinot/pull/15919#discussion_r2113590167
##########
pinot-common/src/main/java/org/apache/pinot/common/datablock/DataBlockUtils.java:
##########
@@ -102,19 +97,6 @@ private DataBlockUtils() {
static final int VERSION_TYPE_SHIFT = 5;
- public static MetadataBlock getErrorDataBlock(Exception e) {
- if (e instanceof ProcessingException) {
- int errorCodeId = ((ProcessingException) e).getErrorCode();
- return getErrorDataBlock(Collections.singletonMap(errorCodeId,
extractErrorMsg(e)));
- } else if (e instanceof QueryException) {
- int errorCodeId = ((QueryException) e).getErrorCode().getId();
- return getErrorDataBlock(Collections.singletonMap(errorCodeId,
extractErrorMsg(e)));
- } else {
- // TODO: Pass in meaningful error code.
- return getErrorDataBlock(Map.of(QueryErrorCode.UNKNOWN.getId(),
extractErrorMsg(e)));
- }
- }
Review Comment:
This and `getErrorDataBlock(Map<Integer, String> exceptions)` are not used
anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
