Copilot commented on code in PR #15919:
URL: https://github.com/apache/pinot/pull/15919#discussion_r2111322777
##########
pinot-common/src/main/java/org/apache/pinot/common/datablock/ZeroCopyDataBlockSerde.java:
##########
@@ -46,6 +46,10 @@
*/
public class ZeroCopyDataBlockSerde implements DataBlockSerde {
+ private static final int STAGE_ID_FAKE_ERROR_CODE = -1;
Review Comment:
Ensure that the selected fake error codes (-1, -2, -3) cannot conflict with
real error code values in any future changes. Consider documenting this design
decision more explicitly to aid future maintainers.
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/BaseJoinOperator.java:
##########
@@ -327,13 +327,15 @@ protected boolean isMaxRowsLimitReached(int
numJoinedRows) {
protected static void throwForJoinRowLimitExceeded(String reason) {
throw QueryErrorCode.SERVER_RESOURCE_LIMIT_EXCEEDED.asException(
reason
- + ". Consider increasing the limit for the maximum number of rows in a
join either via the query option '"
- + QueryOptionKey.MAX_ROWS_IN_JOIN + "' or the '" +
JoinHintOptions.MAX_ROWS_IN_JOIN + "' hint in the '"
- + PinotHintOptions.JOIN_HINT_OPTIONS
- + "'. Alternatively, if partial results are acceptable, the join
overflow mode can be set to '"
- + JoinOverFlowMode.BREAK.name() + "' either via the query option '" +
QueryOptionKey.JOIN_OVERFLOW_MODE
- + "' or the '" + JoinHintOptions.JOIN_OVERFLOW_MODE + "' hint in the
'" + PinotHintOptions.JOIN_HINT_OPTIONS
- + "'.");
+ + ".\nConsider increasing the limit for the maximum number of rows
in a join either via:\n"
Review Comment:
[nitpick] Consider extracting and centralizing this multi-line error message
formatting into a constant or helper method to improve consistency and
maintainability across the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
