Gerrrr commented on code in PR #166:
URL: https://github.com/apache/otava/pull/166#discussion_r3837723573
##########
otava/config.py:
##########
@@ -128,13 +134,18 @@ class
NestedYAMLConfigFileParser(configargparse.ConfigFileParser):
"""
CLI_CONFIG_SECTIONS = [
+ CsvConfig.NAME,
GraphiteConfig.NAME,
GrafanaConfig.NAME,
SlackConfig.NAME,
PostgresConfig.NAME,
BigQueryConfig.NAME,
]
+ CONFIG_KEY_ALIASES = {
Review Comment:
I agree that since `quotechar` is ignored today, it makes sense to rename
it. Let's do the following:
1. Remove `CONFIG_KEY_ALIASES`.
2. use `quote_char` as yaml config and `--csv-quote-char` for CLI,
`CSV_QUOTE_CHAR` as env variable.
Please also rebase this PR against latest master - I had to update
dependencies to fix CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
