Gerrrr commented on code in PR #166:
URL: https://github.com/apache/otava/pull/166#discussion_r3763135046
##########
otava/config.py:
##########
@@ -128,13 +134,18 @@ class
NestedYAMLConfigFileParser(configargparse.ConfigFileParser):
"""
CLI_CONFIG_SECTIONS = [
+ CsvConfig.NAME,
GraphiteConfig.NAME,
GrafanaConfig.NAME,
SlackConfig.NAME,
PostgresConfig.NAME,
BigQueryConfig.NAME,
]
+ CONFIG_KEY_ALIASES = {
Review Comment:
I am really on the fence with `CONFIG_KEY_ALIASES`. @MrlixiangWE can you
please elaborate your thoughts on why do we want to introduce them?
My take is, if we really dislike `quotechar` - now is the time to break
backwards compatibility and rename it to `quote-char` everywhere (although, I'd
like to know the justification for it). OTOH if we can live with `quotechar`,
why don't we just add `csv-quotechar` and call it a day?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
