henrikingo commented on PR #161: URL: https://github.com/apache/otava/pull/161#issuecomment-4732181296
Okay @Gerrrr and others, I think this is the first attempt at something actually worth reviewing seriously. Hopefully we can merge this to unlock 3 other pr's waiting on this one. I've done some docstrings at strategic locations, but in the end I guess I did fairly little :param: type of docs. Code should be easier to follow for example because constructors were broken into 3-4 different factory methods each of which does one thing only. Happy to add more comments if needed, but also didn't want to overdo it and curious to see your reaction now. On the testing side I installed pytest-cov to keep me honest, and then did something I never did before: 100% code covreage with unit tests! I feel like this could become a thing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
