Author: surajk
Date: Mon Oct 29 07:50:40 2018
New Revision: 1845080
URL: http://svn.apache.org/viewvc?rev=1845080&view=rev
Log:
Improved: Consistency and Readability improvements for log tag.
(OFBIZ-8929)
Thanks Devanshu Vyas for providing the updated patch.
Modified:
ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/payment/PaymentServices.xml
ofbiz/ofbiz-framework/trunk/applications/content/minilang/compdoc/CompDocServices.xml
ofbiz/ofbiz-framework/trunk/applications/product/minilang/product/storage/FacilityContactMechServices.xml
Modified:
ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/payment/PaymentServices.xml
URL:
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/payment/PaymentServices.xml?rev=1845080&r1=1845079&r2=1845080&view=diff
==============================================================================
---
ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/payment/PaymentServices.xml
(original)
+++
ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/payment/PaymentServices.xml
Mon Oct 29 07:50:40 2018
@@ -988,7 +988,7 @@ under the License.
<set field="convertUomInMap.originalValue"
from-field="orderHeader.grandTotal" />
<set field="convertUomInMap.uomId"
from-field="orderHeader.currencyUom" />
<set field="convertUomInMap.uomIdTo"
from-field="partyAcctgPreference.baseCurrencyUomId" />
- <log message="convertUomInMap = ${convertUomInMap}"
level="info" />
+ <log level="info" message="convertUomInMap =
${convertUomInMap}"/>
<call-service service-name="convertUom"
in-map-name="convertUomInMap">
<result-to-field result-name="convertedValue"
field="parameters.amount" />
</call-service>
Modified:
ofbiz/ofbiz-framework/trunk/applications/content/minilang/compdoc/CompDocServices.xml
URL:
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/content/minilang/compdoc/CompDocServices.xml?rev=1845080&r1=1845079&r2=1845080&view=diff
==============================================================================
---
ofbiz/ofbiz-framework/trunk/applications/content/minilang/compdoc/CompDocServices.xml
(original)
+++
ofbiz/ofbiz-framework/trunk/applications/content/minilang/compdoc/CompDocServices.xml
Mon Oct 29 07:50:40 2018
@@ -25,7 +25,7 @@ under the License.
<entity-one entity-name="Content" value-field="rootTemplateContent">
<field-map field-name="contentId"
from-field="parameters.instanceOfContentId"/>
</entity-one>
- <log message="genCompDocInstance> rootTemplateContent:
${rootTemplateContent}" level="info"/>
+ <log level="info" message="genCompDocInstance> rootTemplateContent:
${rootTemplateContent}"/>
<!-- if not passed in, get latest template contentRevisionSeqId from
db -->
<if-empty field="parameters.contentRevisionSeqId">
@@ -45,7 +45,7 @@ under the License.
<set from-field="parameters.contentRevisionSeqId"
field="contentRevisionSeqId"/>
</else>
</if-empty>
- <log message="genCompDocInstance> contentRevisionSeqId:
${contentRevisionSeqId}" level="info"/>
+ <log level="info" message="genCompDocInstance> contentRevisionSeqId:
${contentRevisionSeqId}"/>
<make-value entity-name="Content" value-field="rootInstanceContent"/>
<if-empty field="parameters.rootInstanceContentId">
@@ -77,12 +77,12 @@ under the License.
<set value="COMPDOC_INSTANCE"
field="rootInstanceContent.contentTypeId"/>
<create-value value-field="rootInstanceContent"/>
- <log message="genCompDocInstance 3> rootInstanceContent:
${rootInstanceContent}" level="info"/>
+ <log level="info" message="genCompDocInstance 3> rootInstanceContent:
${rootInstanceContent}"/>
<field-to-result field="rootInstanceContent.contentId"
result-name="contentId"/>
<set from-field="parameters.instanceOfContentId"
field="parentTemplateContentId"/>
<set from-field="rootInstanceContent.contentId"
field="parentInstanceContentId"/>
- <log message="genCompDocInstance 4> parentTemplateContentId:
${parentTemplateContentId}" level="info"/>
- <log message="genCompDocInstance 5> parentInstanceContentId:
${parentInstanceContentId}" level="info"/>
+ <log level="info" message="genCompDocInstance 4>
parentTemplateContentId: ${parentTemplateContentId}"/>
+ <log level="info" message="genCompDocInstance 5>
parentInstanceContentId: ${parentInstanceContentId}"/>
<set from-field="parentInstanceContentId"
field="revisionMap.contentId"/>
<set from-field="parentInstanceContentId"
field="revisionMap.itemContentId"/>
<set from-field="parameters.userLogin" field="revisionMap.userLogin"/>
@@ -107,8 +107,8 @@ under the License.
<simple-method method-name="genInstanceChildCompDocs"
short-description="Create CompDoc">
<set from-field="parentTemplateContentId"
field="thisTemplateContentId"/>
<set from-field="parentInstanceContentId"
field="thisInstanceContentId"/>
- <log message="genInstanceChildCompDocs 0> thisTemplateContentId:
${thisTemplateContentId}" level="info"/>
- <log message="genInstanceChildCompDocs 1> thisInstanceContentId:
${thisInstanceContentId}" level="info"/>
+ <log level="info" message="genInstanceChildCompDocs 0>
thisTemplateContentId: ${thisTemplateContentId}"/>
+ <log level="info" message="genInstanceChildCompDocs 1>
thisInstanceContentId: ${thisInstanceContentId}"/>
<entity-condition entity-name="ContentAssoc" list="contentAssocList">
<condition-list combine="and">
<condition-expr field-name="contentIdTo" operator="equals"
from-field="thisTemplateContentId"/>
@@ -119,7 +119,7 @@ under the License.
</condition-list>
</condition-list>
</entity-condition>
- <log message="genInstanceChildCompDocs 1> contentAssocList:
${contentAssocList}" level="info"/>
+ <log level="info" message="genInstanceChildCompDocs 1>
contentAssocList: ${contentAssocList}"/>
<iterate list="contentAssocList" entry="templateContentAssoc">
<clone-value value-field="templateContent"
new-value-field="instanceContent"/>
Modified:
ofbiz/ofbiz-framework/trunk/applications/product/minilang/product/storage/FacilityContactMechServices.xml
URL:
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/minilang/product/storage/FacilityContactMechServices.xml?rev=1845080&r1=1845079&r2=1845080&view=diff
==============================================================================
---
ofbiz/ofbiz-framework/trunk/applications/product/minilang/product/storage/FacilityContactMechServices.xml
(original)
+++
ofbiz/ofbiz-framework/trunk/applications/product/minilang/product/storage/FacilityContactMechServices.xml
Mon Oct 29 07:50:40 2018
@@ -72,9 +72,9 @@ under the License.
</if-empty>
<check-errors/>
- <log message="parameters: ${parameters}" level="info"/>
+ <log level="info" message="parameters: ${parameters}"/>
<clone-value value-field="facilityContactMech"
new-value-field="newFacilityContactMech"/>
- <log message="parameters: ${parameters}" level="info"/>
+ <log level="info" message="parameters: ${parameters}"/>
<!-- If we already have a new contactMechId don't update ContactMech
-->
<if-empty field="parameters.newContactMechId">
<set-service-fields service-name="updateContactMech"
map="parameters" to-map="updateContactMechMap"/>
