Author: surajk
Date: Mon Oct 29 06:35:15 2018
New Revision: 1845075
URL: http://svn.apache.org/viewvc?rev=1845075&view=rev
Log:
Improved: Consistency and Readability improvements for condition tag.
(OFBIZ-8991)
Thanks Ankush Upadhyay for reporting and Devanshu Vyas for providing the
updated patch.
Modified:
ofbiz/ofbiz-plugins/trunk/ebaystore/servicedef/secas.xml
ofbiz/ofbiz-plugins/trunk/scrum/servicedef/secas.xml
ofbiz/ofbiz-plugins/trunk/solr/entitydef/eecas.xml
Modified: ofbiz/ofbiz-plugins/trunk/ebaystore/servicedef/secas.xml
URL:
http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/ebaystore/servicedef/secas.xml?rev=1845075&r1=1845074&r2=1845075&view=diff
==============================================================================
--- ofbiz/ofbiz-plugins/trunk/ebaystore/servicedef/secas.xml (original)
+++ ofbiz/ofbiz-plugins/trunk/ebaystore/servicedef/secas.xml Mon Oct 29
06:35:15 2018
@@ -21,22 +21,22 @@ under the License.
<service-eca xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/service-eca.xsd";>
<eca service="createEbayProductStorePref" event="commit">
- <condition operator="equals" field-name="enabled" value="Y"/>
- <condition operator="is-not-empty" field-name="serviceName"/>
+ <condition field-name="enabled" operator="equals" value="Y"/>
+ <condition field-name="serviceName" operator="is-not-empty"/>
<action service="startEbayAutoPreference" mode="sync"/>
</eca>
<eca service="updateEbayProductStorePref" event="commit">
- <condition operator="equals" field-name="enabled" value="Y"/>
- <condition operator="is-not-empty" field-name="serviceName"/>
+ <condition field-name="enabled" operator="equals" value="Y"/>
+ <condition field-name="serviceName" operator="is-not-empty"/>
<action service="startEbayAutoPreference" mode="sync"/>
</eca>
<eca service="createEbayProductStorePref" event="commit">
- <condition operator="equals" field-name="enabled" value="N"/>
- <condition operator="is-not-empty" field-name="serviceName"/>
+ <condition field-name="enabled" operator="equals" value="N"/>
+ <condition field-name="serviceName" operator="is-not-empty"/>
<action service="stopEbayAutoPreference" mode="sync"/>
</eca>
<eca service="updateEbayProductStorePref" event="commit">
- <condition operator="equals" field-name="enabled" value="N"/>
+ <condition field-name="enabled" operator="equals" value="N"/>
<action service="stopEbayAutoPreference" mode="sync"/>
</eca>
</service-eca>
Modified: ofbiz/ofbiz-plugins/trunk/scrum/servicedef/secas.xml
URL:
http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/scrum/servicedef/secas.xml?rev=1845075&r1=1845074&r2=1845075&view=diff
==============================================================================
--- ofbiz/ofbiz-plugins/trunk/scrum/servicedef/secas.xml (original)
+++ ofbiz/ofbiz-plugins/trunk/scrum/servicedef/secas.xml Mon Oct 29 06:35:15
2018
@@ -21,51 +21,51 @@ under the License.
<service-eca xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/service-eca.xsd";>
<eca service="updateWorkEffort" event="commit">
- <condition operator="equals" field-name="currentStatusId"
value="STS_COMPLETED"/>
+ <condition field-name="currentStatusId" operator="equals"
value="STS_COMPLETED"/>
<set field-name="webSiteId" env-name="webSiteId"/>
<action service="autoCompleteBacklog" mode="sync"/>
</eca>
<eca service="createWorkEffort" event="commit">
- <condition operator="equals" field-name="currentStatusId"
value="SPRINT_ACTIVE"/>
+ <condition field-name="currentStatusId" operator="equals"
value="SPRINT_ACTIVE"/>
<set field-name="sprintId" env-name="workEffortId"/>
<set field-name="sprintStatusId" env-name="currentStatusId"/>
<set field-name="webSiteId" env-name="webSiteId"/>
<action service="autoScrumNotification" mode="sync"/>
</eca>
<eca service="updateWorkEffort" event="commit">
- <condition operator="equals" field-name="currentStatusId"
value="SPRINT_CLOSED"/>
+ <condition field-name="currentStatusId" operator="equals"
value="SPRINT_CLOSED"/>
<set field-name="sprintId" env-name="workEffortId"/>
<set field-name="sprintStatusId" env-name="currentStatusId"/>
<set field-name="webSiteId" env-name="webSiteId"/>
<action service="autoScrumNotification" mode="sync"/>
</eca>
<eca service="createCustRequest" event="commit">
- <condition operator="equals" field-name="statusId"
value="CRQ_ACCEPTED"/>
+ <condition field-name="statusId" operator="equals"
value="CRQ_ACCEPTED"/>
<set field-name="custRequestStatusId" value="CRQ_ACCEPTED"/>
<set field-name="webSiteId" env-name="webSiteId"/>
<action service="autoScrumNotification" mode="sync"/>
</eca>
<eca service="setCustRequestStatus" event="commit">
<condition field-name="oldStatusId" operator="equals"
value="CRQ_REVIEWED"/>
- <condition operator="equals" field-name="statusId"
value="CRQ_ACCEPTED"/>
+ <condition field-name="statusId" operator="equals"
value="CRQ_ACCEPTED"/>
<set field-name="custRequestStatusId" value="CRQ_ACCEPTED"/>
<set field-name="webSiteId" env-name="webSiteId"/>
<action service="autoScrumNotification" mode="sync"/>
</eca>
<eca service="setCustRequestStatus" event="commit">
- <condition operator="equals" field-name="statusId"
value="CRQ_REVIEWED"/>
+ <condition field-name="statusId" operator="equals"
value="CRQ_REVIEWED"/>
<set field-name="custRequestStatusId" value="CRQ_REVIEWED"/>
<set field-name="webSiteId" env-name="webSiteId"/>
<action service="autoScrumNotification" mode="sync"/>
</eca>
<eca service="setCustRequestStatus" event="commit">
- <condition operator="equals" field-name="statusId"
value="CRQ_COMPLETED"/>
+ <condition field-name="statusId" operator="equals"
value="CRQ_COMPLETED"/>
<set field-name="custRequestStatusId" value="CRQ_COMPLETED"/>
<set field-name="webSiteId" env-name="webSiteId"/>
<action service="autoScrumNotification" mode="sync"/>
</eca>
<eca service="setCustRequestStatus" event="commit">
- <condition operator="equals" field-name="statusId"
value="CRQ_CANCELLED"/>
+ <condition field-name="statusId" operator="equals"
value="CRQ_CANCELLED"/>
<set field-name="custRequestStatusId" value="CRQ_CANCELLED"/>
<set field-name="webSiteId" env-name="webSiteId"/>
<action service="autoScrumNotification" mode="sync"/>
Modified: ofbiz/ofbiz-plugins/trunk/solr/entitydef/eecas.xml
URL:
http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/solr/entitydef/eecas.xml?rev=1845075&r1=1845074&r2=1845075&view=diff
==============================================================================
--- ofbiz/ofbiz-plugins/trunk/solr/entitydef/eecas.xml (original)
+++ ofbiz/ofbiz-plugins/trunk/solr/entitydef/eecas.xml Mon Oct 29 06:35:15 2018
@@ -37,15 +37,15 @@ xsi:noNamespaceSchemaLocation="http://of
<action service="addToSolr" mode="sync" value-attr="instance"/>
</eca>
<eca entity="ProductPrice" operation="create-store-remove" event="return">
- <condition operator="equals" field-name="productPriceTypeId"
value="LIST_PRICE"/>
+ <condition field-name="productPriceTypeId" operator="equals"
value="LIST_PRICE"/>
<action service="addToSolr" mode="sync" value-attr="instance"/>
</eca>
<eca entity="ProductPrice" operation="create-store-remove" event="return">
- <condition operator="equals" field-name="productPriceTypeId"
value="DEFAULT_PRICE"/>
+ <condition field-name="productPriceTypeId" operator="equals"
value="DEFAULT_PRICE"/>
<action service="addToSolr" mode="sync" value-attr="instance"/>
</eca>
<eca entity="ProductPrice" operation="create-store-remove" event="return">
- <condition operator="equals" field-name="productPriceTypeId"
value="DEFAULT_PRICE"/>
+ <condition field-name="productPriceTypeId" operator="equals"
value="DEFAULT_PRICE"/>
<action service="addToSolr" mode="sync" value-attr="instance"/>
</eca>
-->
