xiaoxiang781216 commented on code in PR #2171:
URL: https://github.com/apache/nuttx-apps/pull/2171#discussion_r1378410290
##########
examples/serialrx/serialrx_main.c:
##########
@@ -118,8 +118,7 @@ int main(int argc, FAR char *argv[])
while (cnt < bytecount)
{
#ifdef CONFIG_EXAMPLES_SERIALRX_BUFFERED
- size_t n = fread(buf, 1, 26, f);
Review Comment:
Ok, but after you finish the investigation is better to remove the temp
change. If you think the temp change is worth to upstream, please split to the
different patch. It's important to ensure one patch fix one problem, so the
reviewer could understand your change quickly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
