xiaoxiang781216 commented on code in PR #2171:
URL: https://github.com/apache/nuttx-apps/pull/2171#discussion_r1378373428
##########
examples/serialrx/Kconfig:
##########
@@ -39,22 +39,22 @@ config EXAMPLES_SERIALRX_DEVPATH
choice
prompt "Output method"
- default EXAMPLES_SERIALRX_PRINTHYPHEN
+ default EXAMPLES_SERIALRX_PRINTSTR
-config EXAMPLES_SERIALRX_PRINTHYPHEN
Review Comment:
why change the order, let's keep as before
##########
examples/serialrx/serialrx_main.c:
##########
@@ -118,8 +118,7 @@ int main(int argc, FAR char *argv[])
while (cnt < bytecount)
{
#ifdef CONFIG_EXAMPLES_SERIALRX_BUFFERED
- size_t n = fread(buf, 1, 26, f);
Review Comment:
why make the follow change
##########
examples/serialrx/Kconfig:
##########
@@ -39,22 +39,22 @@ config EXAMPLES_SERIALRX_DEVPATH
choice
prompt "Output method"
- default EXAMPLES_SERIALRX_PRINTHYPHEN
+ default EXAMPLES_SERIALRX_PRINTSTR
Review Comment:
why change the default setting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
