xiaoxiang781216 commented on code in PR #10602: URL: https://github.com/apache/nuttx/pull/10602#discussion_r1335167602
########## include/nuttx/fs/fs.h: ########## @@ -497,6 +546,8 @@ struct file_struct FAR struct file_struct *fs_next; /* Pointer to next file stream */ rmutex_t fs_lock; /* Recursive lock */ int fs_fd; /* File descriptor associated with stream */ Review Comment: but the current design waste the memory: 1. fs_fd dup with fs_cookie.cookie 2. fs_callbacks dup with fs_cookie.cookie_io total bytes equal to 20(32bit) or 36(64bit), it can be avoided with the better implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
